Make code generation (for Java interoperability) opt-in #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code generation as implemented in #334 is currently rather experimental and throws a lot of exceptions on recent Kotlin versions. Until this is addressed, it would be a better user experience if we just disable code generation by default and let advanced users opt-in by setting
{ "kotlin.codegen.enabled": true }The downside is that Java interoperability will no longer work without this option, but given that it doesn't really seem to work properly in the current state, I believe making it opt-in and experimental for now would be an improvement over the status quo.
cc @daplf